-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions of peer dependencies to allow latest Vite and Vite Svelte plugin #159
Conversation
…elte plugin Now that [Vite 5 has been released](https://vitejs.dev/blog/announcing-vite5), it would be nice to have te versions of the peer dependencies for it and the Svelte Vite plugin which uses Vite, updated to the latest versions. If this could be published as a new release that would most awesome!
I don't think it's a good idea to drop support for vite4 now |
@j3rem1e are you able to say a little more about the thinking behind that? I agree that vite 4 should still be supported since it is widely used. To do this and support vite 5, a new major release of this package could be made that supports vite >=5 while still doing minor release bumps for the current major version that requires vite <= 4. Curious to hear your thoughts on that path forward. |
Co-authored-by: Andrey Sitnik <[email protected]>
Any news here? It's two weeks and I would appreciate this addon working with Vite5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can do this without a breaking change, supporting both versions?
Otherwise I'd expect some logic changes as well somewhere.
I would advice against dropping support for Vite 4 given that SvelteKit still uses it.
Co-authored-by: Jeppe Reinhold <[email protected]>
If someone is willing to test this addon in a Vite 5 project and can confirm it works fine, I'd be happy to merge and release this. |
@JReinhold We would need a package to include to test it with our Svelte project. Any advice how to come up with that? |
@matths could you use the existing release and update the package.json as is done in this PR? It's a 2 line change. |
I tested this in a new sveltekit project per the sveltekit docs: npm create svelte@latest my-app
cd my-app
npm install and in my "@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"vite": "^5.0.3",
"svelte": "^4.2.7",
... I then ran |
🚀 PR was released in |
Fixes #161
Now that Vite 5 has been released, it would be nice to have te versions of the peer dependencies for it and the Svelte Vite plugin which uses Vite, updated to the latest versions. If this could be published as a new release that would most awesome!