Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export condition #125

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix export condition #125

merged 1 commit into from
Aug 23, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 23, 2023

Closes #124. You only need to use the svelte export condition if you're exporting both compiled and uncompiled .svelte files, which is pretty rare

📦 Published PR as canary version: 3.0.8--canary.125.172fd41.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@JReinhold
Copy link
Collaborator

@michael-wynne can you confirm that the canary release fixes your issue?

@michael-wynne
Copy link

Hi @JReinhold and @benmccann, yes it looks like this did fix my issue. Thank you both, this is super helpful!

@JReinhold JReinhold changed the title Update export condition Fix export condition Aug 23, 2023
@JReinhold JReinhold added bug Something isn't working patch Increment the patch version when merged labels Aug 23, 2023
@JReinhold JReinhold merged commit 7725af3 into main Aug 23, 2023
@JReinhold JReinhold deleted the benmccann-patch-1 branch August 23, 2023 20:38
@shilman
Copy link
Member

shilman commented Aug 23, 2023

🚀 PR was released in v3.0.9 🚀

@shilman shilman added the released This issue/pull request has been released. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Package path . is not exported from package @storybook/addon-svelte-csf
4 participants