Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing types by adding back main and types fields #118

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix missing types by adding back main and types fields #118

merged 1 commit into from
Aug 1, 2023

Conversation

hobbes7878
Copy link
Collaborator

@hobbes7878 hobbes7878 commented Aug 1, 2023 •
edited
Loading

… so TS node10 moduleResolution still works per #116.

@hobbes7878 hobbes7878 requested a review from JReinhold August 1, 2023 12:08
@JReinhold JReinhold changed the title Adds back main and types fields Adds back main and types fields Aug 1, 2023
@JReinhold JReinhold changed the title Adds back main and types fields Fix missing types by adding back main and types fields Aug 1, 2023
@JReinhold JReinhold added bug Something isn't working patch Increment the patch version when merged labels Aug 1, 2023
@JReinhold
Copy link
Collaborator

JReinhold commented Aug 1, 2023 •
edited
Loading

I'm just testing the canary 3.0.7--canary.d7ef15d.0 against https://github.com/olafurw/addon-svelte-csf-import-bug to make sure it works.

EDIT: Works, in the repro at least

@JReinhold JReinhold merged commit 3ced913 into main Aug 1, 2023
@JReinhold JReinhold deleted the module-settings branch August 1, 2023 12:32
@olafurw
Copy link

olafurw commented Aug 1, 2023

Tested locally with canary version, works great.

https://github.com/olafurw/addon-svelte-csf-import-bug/actions/runs/5726789194/job/15517919448

Thank you @hobbes7878 and @JReinhold

@shilman
Copy link
Member

shilman commented Aug 1, 2023

🚀 PR was released in v3.0.7 🚀

@shilman shilman added the released This issue/pull request has been released. label Aug 1, 2023
@paoloricciuti
Copy link
Collaborator

Uh that's strange...my fix was working locally...than all of a sudden it stopped working. This seems to have fixed it once and for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hobbes7878 @JReinhold @olafurw @shilman @paoloricciuti