Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Create autoconfig script for tailwindcss & Material UI #42

Merged
merged 24 commits into from
Jun 8, 2023

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented May 16, 2023

📦 Published PR as canary version: 1.1.0-canary.42.ff1bf8d.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@socket-security
Copy link

socket-security bot commented May 16, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Shell access @storybook/telemetry 7.0.12 package.json via [email protected]
Uses eval @storybook/manager 7.0.12 package.json via [email protected]
Uses eval @storybook/preview 7.0.12 package.json via @storybook/[email protected], @storybook/[email protected]

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@socket-security
Copy link

socket-security bot commented Jun 6, 2023

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@storybook/core-common 🆕 7.0.12 filesystem +5 2.6 MB shilman
@babel/types 🆕 7.21.5 None +1 2.42 MB nicolo-ribaudo
recast 🆕 0.23.2 None +0 244 kB eventualbuddha
@storybook/csf-tools 🆕 7.0.12 None +5 2.8 MB shilman
@storybook/builder-webpack5 ⬆️ 7.0.2...7.0.12 filesystem +21/-23 9.01 MB shilman
@storybook/api ⬆️ 7.0.2...7.0.12 None +9/-10 3.48 MB shilman
storybook ⬆️ 7.0.2...7.0.12 None +19/-24 19 MB shilman
@storybook/react-vite ⬆️ 7.0.2...7.0.12 None +20/-22 4.72 MB shilman
@storybook/addon-essentials ⬆️ 7.0.2...7.0.12 None +31/-32 9.67 MB shilman
@storybook/node-logger ⬆️ 7.0.7...7.0.12 None +0/-0 6.56 kB shilman
@storybook/components ⬆️ 7.0.2...7.0.12 None +6/-7 7.46 MB shilman
@storybook/theming ⬆️ 7.0.2...7.0.12 None +1/-1 731 kB shilman
@storybook/react ⬆️ 7.0.2...7.0.12 None +13/-15 3.97 MB shilman
@storybook/core-events ⬆️ 7.0.2...7.0.12 None +0/-0 19.7 kB shilman
@storybook/manager-api ⬆️ 7.0.2...7.0.12 None +8/-9 3.47 MB shilman
prettier ⬆️ 2.3.1...2.8.8 None +0/-0 11.2 MB prettier-bot
@storybook/preview-api ⬆️ 7.0.2...7.0.12 None +7/-8 3.33 MB shilman
@storybook/types ⬆️ 7.0.2...7.0.12 None +3/-4 2.52 MB shilman

Footnotes

  1. https://docs.socket.dev

@ShaunEvening ShaunEvening marked this pull request as ready for review June 7, 2023 13:45
@ShaunEvening ShaunEvening added the minor Increment the minor version when merged label Jun 7, 2023
docs/api.md Outdated Show resolved Hide resolved
docs/auto-configuration.md Outdated Show resolved Hide resolved
docs/auto-configuration.md Outdated Show resolved Hide resolved
@ShaunEvening ShaunEvening changed the title [WIP] Create autoconfig script for tailwindcss Create autoconfig script for tailwindcss & Material UI Jun 7, 2023
src/postinstall.ts Outdated Show resolved Hide resolved
export type SupportedStylingTools =
typeof SUPPORTED_STYLING_TOOLS[keyof typeof SUPPORTED_STYLING_TOOLS];

export interface ToolConfigurationStrategy {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a beautiful abstraction! 😍

Thanks for taking time to JSDoc it.

Copy link

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo! I'm trusting your comprehensive tests for the actual business logic of it. The abstractions seem well thought-out! 👏

@ShaunEvening ShaunEvening merged commit 62eaa17 into main Jun 8, 2023
@ShaunEvening ShaunEvening deleted the feature/auto-config-tailwind branch June 8, 2023 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants