Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

feat(sass): Add SASS support to addon #4

Merged
merged 5 commits into from
Mar 2, 2023
Merged

feat(sass): Add SASS support to addon #4

merged 5 commits into from
Mar 2, 2023

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Feb 28, 2023 •
edited
Loading

What Changed

  • Split webpackFinal into a few files for readability
  • Add sass and scssBuildRule options to addon
  • Update Bootstrap instructions to include optional sass config

How I tested

  • Tried importing and using Bootstrap's .scss files
📦 Published PR as canary version: 0.3.0-canary.4.7fc78e3.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@ShaunEvening ShaunEvening self-assigned this Feb 28, 2023
@ShaunEvening ShaunEvening added the minor Increment the minor version when merged label Feb 28, 2023
@socket-security

This comment was marked as resolved.

Sign in to view
@ShaunEvening ShaunEvening marked this pull request as ready for review March 2, 2023 16:02
@ShaunEvening ShaunEvening merged commit 1644c69 into main Mar 2, 2023
@ShaunEvening ShaunEvening deleted the sass-support branch March 2, 2023 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ShaunEvening ShaunEvening

Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShaunEvening