This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 2
Implement bare minimum confetti component #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
valentinpalkovic
force-pushed
the
valentin/confetti-wrapper
branch
from
May 26, 2023 11:13
fd39608
to
914a170
Compare
valentinpalkovic
force-pushed
the
valentin/confetti-wrapper
branch
from
May 26, 2023 11:15
914a170
to
4770c35
Compare
yannbf
reviewed
May 26, 2023
yannbf
reviewed
May 26, 2023
yannbf
reviewed
May 26, 2023
@yannbf Otherwise good? Can we merge? |
@yannbf I have moved the div creation inside the component. Good to merge? |
yannbf
approved these changes
May 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
I have created a reusable confetti component, which can be placed on the screen to display some confetti.
📦 Published PR as canary version:
0.0.8--canary.7.679dfa7.0
✨ Test out this PR locally via: