Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Implement bare minimum confetti component #7

Merged
merged 2 commits into from
May 30, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 26, 2023

Closes #10

I have created a reusable confetti component, which can be placed on the screen to display some confetti.

📦 Published PR as canary version: 0.0.8--canary.7.679dfa7.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +1 alampros

@valentinpalkovic valentinpalkovic force-pushed the valentin/confetti-wrapper branch from fd39608 to 914a170 Compare May 26, 2023 11:13
@valentinpalkovic valentinpalkovic force-pushed the valentin/confetti-wrapper branch from 914a170 to 4770c35 Compare May 26, 2023 11:15
@valentinpalkovic valentinpalkovic requested a review from yannbf May 26, 2023 11:28
@valentinpalkovic valentinpalkovic self-assigned this May 26, 2023
@yannbf
Copy link
Member

yannbf commented May 26, 2023

Not sure what's going on, but the mdx stories are broken:
image

@valentinpalkovic
Copy link
Contributor Author

@yannbf Otherwise good? Can we merge?

@valentinpalkovic
Copy link
Contributor Author

@yannbf I have moved the div creation inside the component. Good to merge?

@valentinpalkovic valentinpalkovic merged commit 0b11d0c into main May 30, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/confetti-wrapper branch May 30, 2023 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project - Onboarding]: Implement dummy Confetti component
2 participants