Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Improve write a story modal #38

Merged
merged 9 commits into from
Jun 7, 2023
Merged

Improve write a story modal #38

merged 9 commits into from
Jun 7, 2023

Conversation

cdedreuille
Copy link
Collaborator

@cdedreuille cdedreuille commented Jun 7, 2023 •
edited
Loading

In this PR, I improved the write a story part:

  • Fixed the blurred text
  • Fixed the horizontal scroll
  • Added colours on the background on the right panel
  • Adjusted paddings and positioning of the content

Closes #25
Closes #32

CleanShot 2023-06-07 at 12 15 39@2x
📦 Published PR as canary version: 0.0.19--canary.38.3c859a1.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@cdedreuille cdedreuille marked this pull request as ready for review June 7, 2023 11:08
valentinpalkovic
valentinpalkovic suggested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@valentinpalkovic valentinpalkovic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow is currently broken. After the "args modal" the modal suddenly closes. - UPDATE: Just on chromatic. Locally everything is fine.

@cdedreuille cdedreuille merged commit ae90780 into main Jun 7, 2023
@cdedreuille cdedreuille deleted the write-story-polish branch June 7, 2023 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cdedreuille @valentinpalkovic