Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Implemented bare minimum list component #19

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jun 1, 2023

Closes storybookjs/storybook#22786

We have implemented a bare minimum list component, which should be later used for the "How to write your first Story" step

Co-authored-by: @liwn9527

📦 Published PR as canary version: 0.0.12--canary.19.c7c01ab.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@valentinpalkovic valentinpalkovic force-pushed the valentin/list-component branch from b878c05 to 53634b6 Compare June 1, 2023 13:11
@valentinpalkovic valentinpalkovic requested a review from yannbf June 1, 2023 13:11
@valentinpalkovic valentinpalkovic self-assigned this Jun 1, 2023
@valentinpalkovic valentinpalkovic removed the request for review from yannbf June 1, 2023 13:18
@valentinpalkovic valentinpalkovic marked this pull request as draft June 1, 2023 13:19
@valentinpalkovic valentinpalkovic force-pushed the valentin/list-component branch from 53634b6 to 8e33ea9 Compare June 1, 2023 14:01
@valentinpalkovic valentinpalkovic marked this pull request as ready for review June 1, 2023 14:01
@valentinpalkovic valentinpalkovic requested a review from yannbf June 1, 2023 14:01
@valentinpalkovic valentinpalkovic force-pushed the valentin/list-component branch from 8e33ea9 to 4c5cf40 Compare June 1, 2023 14:32
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fantastic contribution 👏 @liwn9527

src/components/List/List.stories.tsx Outdated Show resolved Hide resolved
src/components/List/List.stories.tsx Outdated Show resolved Hide resolved
src/components/List/List.stories.tsx Show resolved Hide resolved
src/components/List/ListItem/ListItem.tsx Outdated Show resolved Hide resolved
src/components/List/ListItem/ListItem.tsx Outdated Show resolved Hide resolved
@valentinpalkovic valentinpalkovic merged commit 0240110 into main Jun 1, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/list-component branch June 1, 2023 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project - Onboarding]: Implement list component (without styling)
2 participants