Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Fix SPA deep-linking problem #6

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fix SPA deep-linking problem #6

merged 1 commit into from
Apr 20, 2017

Conversation

shilman
Copy link
Contributor

@shilman shilman commented Apr 19, 2017

@shilman shilman requested review from thani-sh and ndelangen April 19, 2017 14:39
@arunoda
Copy link
Contributor

arunoda commented Apr 19, 2017

That's a okay solution (specially as a hot-fix)
But it serves the page with a 404 status code. Even though Google could read the page (via JS), status code might cause issues.

@shilman shilman requested a review from arunoda April 19, 2017 14:46
@arunoda arunoda merged commit f0117ff into source Apr 20, 2017
@arunoda arunoda deleted the 912-fix-deep-links branch April 20, 2017 00:52
arunoda
arunoda reviewed Apr 20, 2017
View reviewed changes
Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking this as it's a hot fix to the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arunoda arunoda arunoda left review comments

@ndelangen ndelangen ndelangen approved these changes

@thani-sh thani-sh thani-sh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shilman @arunoda @thani-sh @ndelangen