This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Avoid preview re-mounting when switching to the full screen mode #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make sure that the preview content is not reset when go full-screen. Story content updated by addons like knobs may get reset back if not.
|
Does the new react-komposer PR changes what's happening here? |
|
@arunoda Tried with the newest react komposer. Nothing changes. The first time, going full screen resets everything. |
|
@roonyh Okay. Then that's something else. |
|
This is great. |
arunoda
changed the title
arunoda
changed the title
ndelangen
pushed a commit
that referenced
this pull request
Apr 2, 2017
Remove unused knobs from panel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make sure that the preview content is not reset when go full-screen. Story content updated by addons like knobs may get reset back if not.