Merge pull request #198 from storm-devs/fix/geometry-bsp-crash

Fix crash caused by some broken models
storm-devs · Sep 5, 2021 · dd81e1b · dd81e1b
2 parents 3ceeead + d6eb6d0
commit dd81e1b
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/libs/geometry/src/collide.cpp b/src/libs/geometry/src/collide.cpp
@@ -311,6 +311,11 @@ rec_loop:;
         {
             const long face = (static_cast<long>(*(pface + 2)) << 16) | (static_cast<long>(*(pface + 1)) << 8) |
                               (static_cast<long>(*(pface + 0)) << 0);
+            // "fix" for broken models
+            if (face < 0 || face >= sizeof(trgclip) / sizeof(*trgclip))
+            {
+                continue;
+            }
 
             // this triangle was added before
             if (trgclip[face] != attempt)