Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parts listing is broken #95

Closed
mniewrzal opened this issue Apr 25, 2022 · 1 comment
Closed

Parts listing is broken #95

mniewrzal opened this issue Apr 25, 2022 · 1 comment
Assignees
@mniewrzal
Labels
bug Something isn't working

Comments

@mniewrzal
Copy link
Contributor

When uploaded object have more than 1000 segments then listing all parts will be broken. We have two issues here:

  • (*PartIterator).more is unused so we will never jump to the next page of segments
  • single part segments can be listing by two pages and we are not combining results from both pages
@mniewrzal mniewrzal added the bug Something isn't working label Apr 25, 2022
@mniewrzal mniewrzal moved this to Backlog in Metainfo Team Apr 25, 2022
@storjBuildBot
Copy link
Collaborator

Change https://review.dev.storj.io/c/storj/uplink/+/7358 mentions this issue.

@mniewrzal mniewrzal self-assigned this Apr 25, 2022
Repository owner moved this from Backlog to Merged (Pending Relese/Deploy) in Metainfo Team Apr 25, 2022
mniewrzal added a commit that referenced this issue Apr 28, 2022
@mniewrzal
uplink: fix uploaded parts listing
c984e09 
Listing parts when we had more than single page was broken.
This change fix paging and additional case where segments
from single part are in two different list results.

Fixes #95

Change-Id: I896f490b730454fa3a2f71a0119d540c9e460449
@mniewrzal mniewrzal mentioned this issue Apr 28, 2022
Closed
@mniewrzal mniewrzal moved this from Merged (Pending Relese/Deploy) to Done/Deployed in Metainfo Team Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mniewrzal mniewrzal

Labels
bug Something isn't working
Projects
No open projects
Metainfo Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mniewrzal @storjBuildBot