Fix Settings Corruption

[tacticalchihuahua]

This PR ensures that disk writes to the settings.json file are synchronous, preventing other writes from occurring in parallel which can lead to a corrupted settings file.

Should fix #183 and #181

@MrFancyMonocle - review/test/merge?

[GalumphingCallooh]

Looks good,I'd maybe add some sync error handling:

try {
    fs.writeFileSync(this._path, JSON.stringify(this.toObject(), null, 2));
    callback();
  }
  catch(err) {
    callback(err)
  }

[tacticalchihuahua]

Good call, added error handler and unit test.

FYI - I'm not calling callback within the try block because if the callback raised an error, it would misbehave by calling itself again with the error (in your example).

[littleskunk]

autobin binaries (only available for team members)
last commit: 1b8165136acde32af5ba6b42eceb4832b9e2485c
driveshare_0.5.0.amd64.deb

[GalumphingCallooh]

Indeed, good call, merging.