-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing one of multiple db objects for the same db file causes failure #209
Comments
IMPORTANT NOTE (implementation): if a db handle object has been closed, it should abort all attempts to execute SQL statements and transactions, and should reject any future attempt to close with an error callback (as already tested in commit 2e31d46). |
Clean separation between SQL tests (which should apply to both Web SQL and this plugin) and plugin-specific tests. Add reproduction of minor bug #204. Move reproduction of #209 to section with plugin-specific tests. Mark some plugin db tests that were added by Mark Oppenheim (mailto:[email protected]) as "Needed to support some large-scale applications". Test repeatedly open and close db two ways (whether or not to wait for open callback before closing db) Add another test of repeatedly open and delete db (wait for open callback before deleting db) Needed for #184/#204/#209/#210/#211/#213.
CHANGES: - Use per-db state to properly handle transactions requested on a database that is being opened (#184). - Report an error upon attempt to close database multiple times. TEST: - Reproduce BUGs #204/#209 - Expand some existing scenarios - Prepare test suite for upcoming fixes and improvements (#184/#204/#209/#210/#211/#213)
CHANGES: - Use per-db state to properly handle transactions requested on a database that is being opened (#184). - Report an error upon attempt to close database multiple times. TEST: - Reproduce BUGs #204/#209 - Expand some existing scenarios - Prepare test suite for upcoming fixes and improvements (#184/#204/#209/#210/#211/#213)
Fixed in documentation: using the A FUTURE TODO is to add a |
While it is possible to support db connection objects to the same db file, closing one of the db connection objects
quietlybreaks the other db connection.UPDATED REPRODUCTION SCENARIO: The following reproduction scenario fails
with a timeout:This issue was discovered by consideration of some CoffeeScript/Javascript restructuring and possible redesign to support solution to #184.
The text was updated successfully, but these errors were encountered: