Cipher Migrate feature for iOS and Android #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you going to merge this? Because of this issue we have to fork the code and update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new feature for those who want to upgrade from an old version of the plugin to a newer one without making its users uninstall and reinstall the application.
The feature is activated by adding a cipherMigrate param "true" when calling window.sqlitePlugin.openDatabase. It only executes the "PRAGMA cipher_migrate" sentence if the cipherMigrate param is true and there is some error when opening the database.
It has been tested successfully on iOS and Android by upgrading apps from plugin version 0.1.12-rc3 to plugin version 0.5.4.
I have not updated the docs yet, because I thought that maybe this needs some discussion, but I will do if there is no problem with the feature.