This repository is currently being migrated. It's locked while the migration is in progress.
Add Makefile target to build and install into GOPATH #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusenask
approved these changes
Jan 23, 2018
JoeReid
reviewed
Jan 23, 2018
| @@ -10,6 +10,10 @@ build: | |||
| @echo "++ Building storageos binary" | |||
| cd cmd/storageos && CGO_ENABLED=0 go build -ldflags "$(LDFLAGS)" | |||
|
|
|||
| install: | |||
| @echo "++ Installing storageos binary into \$GOPATH/bin" | |||
| touch version/client.go && go install -ldflags "$(LDFLAGS)" github.com/storageos/go-cli/cmd/storageos | |||
There was a problem hiding this comment.
go install -a will also force re-build, as it supports the same flags as go build
There was a problem hiding this comment.
yes, but apparently a lot slower: golang/go#18369 (comment)
I'm fine with either.
There was a problem hiding this comment.
I'll leave this to your discretion.
Otherwise this PR LGTM
JoeReid
approved these changes
Jan 24, 2018
domodwyer
added a commit
that referenced
this pull request
Jun 26, 2020
…dd-offline-delete-support-for-delete-volume to master Squashed commit of the following: commit 0d590ac3fe64713d78312a0a51c79275c8a69959 Author: Fraser Savage <[email protected]> Date: Tue May 19 10:21:05 2020 +0100 Less confusor commit 726478f41743ab1914f8f500bfb1ef25c7712f62 Author: Fraser Savage <[email protected]> Date: Mon May 18 11:31:57 2020 +0100 cmd/delete: Support offline delete
domodwyer
added a commit
that referenced
this pull request
Jun 26, 2020
…dd-offline-delete-support-for-delete-volume to master Squashed commit of the following: commit 0d590ac3fe64713d78312a0a51c79275c8a69959 Author: Fraser Savage <[email protected]> Date: Tue May 19 10:21:05 2020 +0100 Less confusor commit 726478f41743ab1914f8f500bfb1ef25c7712f62 Author: Fraser Savage <[email protected]> Date: Mon May 18 11:31:57 2020 +0100 cmd/delete: Support offline delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves having to copy the binary into your path when developing.
The
touch version/client.gojust makes sure you're rebuilding it.