Make GPT default label type on all architectures #1317
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Nov 14, 2024
| elif arch.is_aarch64() or arch.is_x86(bits=64) or (arch.is_efi() and not arch.is_arm()): | ||
| label_types = ["gpt", "msdos"] | ||
| # prefet msdos on 32-bit ARM | ||
| elif arch.is_arm(): |
There was a problem hiding this comment.
It's confusing to me that is_arm means 32 bit, is this because the other arch string is aarch64?
Maybe worth a followup to rename is_arm to is_arm32 or so
There was a problem hiding this comment.
The name is unfortunate, I had to check myself what is_arm actually means. We have arch.is_arm which means 32bit ARM and arch.is_aarch64 for 64bit ARM.
Exceptions are DASD drives on s390 and 32bit ARM. Everywhere else GPT will be default.
vojtechtrefny
force-pushed
the
rhel10-branch_gpt-by-default
branch
from
a5d3ba8
to
35c37e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions are DASD drives on s390 and 32bit ARM. Everywhere else GPT will be default.