feat: revocation handler #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Oct 10, 2023
Co-authored-by: Alan Shaw <[email protected]>
This was referenced Oct 10, 2023
travis
pushed a commit
that referenced
this pull request
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- ## [9.5.0](capabilities-v9.4.0...capabilities-v9.5.0) (2023-10-10) ### Features * revocation handler ([#960](#960)) ([91f52c6](91f52c6)) ### Bug Fixes * upgrade to latest ts ([#962](#962)) ([711e3f7](711e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
travis
added a commit
that referenced
this pull request
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- ## [5.9.0](upload-api-v5.8.0...upload-api-v5.9.0) (2023-10-10) ### Features * revocation handler ([#960](#960)) ([91f52c6](91f52c6)) * upgrade to ucanto@9 ([#951](#951)) ([d72faf1](d72faf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ucan/revokecapability and a ucanto server hook that performs the revocation checks.I ended up changing revocations store interface to avoid serializing / deserializing UCN CIDs and to layout data in a way that it's would be more efficient to perform necessary lookups.
queryon the revocations store. If we do that we would be able to uplift logic fromutils/revocation.jsinto ucanto and simplify things here. That said I it's probably better to land thing here first and do the uplifting if we'll have time to do so.