-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: content serve authorization #1590
Merged
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0a98e87
feat: authorize gateway
fforbeck d2735dc
fix tests
fforbeck 5245370
implemented reviewer suggestions
fforbeck a9c36e9
create space and authorize content serve flow
fforbeck 022061e
fix broken tests due to changes in createSpace func
fforbeck 64b08d1
fix authorizeContentServe test
fforbeck 7a395a9
fix and add tests
fforbeck 988ea2d
lint fix
fforbeck 5f414b0
reviewer suggestions implemented
fforbeck d85023d
export authorizeContentServe
fforbeck 8ab9792
fix authorizeContentServe export
fforbeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,13 +13,15 @@ export const provide = (ctx) => | |
|
||
/** | ||
* Checks if the given Principal is an Account. | ||
* | ||
* @param {API.Principal} principal | ||
* @returns {principal is API.Principal<API.DID<'mailto'>>} | ||
*/ | ||
const isAccount = (principal) => principal.did().startsWith('did:mailto:') | ||
|
||
/** | ||
* Returns true when the delegation has a `ucan:*` capability. | ||
* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed lint issue |
||
* @param {API.Delegation} delegation | ||
* @returns boolean | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,8 +147,8 @@ export const execute = async (agent, input) => { | |
* a receipt it will return receipt without running invocation. | ||
* | ||
* @template {Record<string, any>} S | ||
* @param {Types.Invocation} invocation | ||
* @param {Agent<S>} agent | ||
* @param {Types.Invocation} invocation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed lint issue |
||
*/ | ||
export const run = async (agent, invocation) => { | ||
const cached = await agent.context.agentStore.receipts.get(invocation.link()) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,9 @@ export const testAccount = Test.withContext({ | |
assert, | ||
{ client, mail, grantAccess } | ||
) => { | ||
const space = await client.createSpace('test') | ||
const space = await client.createSpace('test', { | ||
skipContentServeAuthorization: true, | ||
}) | ||
const mnemonic = space.toMnemonic() | ||
const { signer } = await Space.fromMnemonic(mnemonic, { name: 'import' }) | ||
assert.deepEqual( | ||
|
@@ -147,7 +149,9 @@ export const testAccount = Test.withContext({ | |
|
||
'multi device workflow': async (asserts, { connect, mail, grantAccess }) => { | ||
const laptop = await connect() | ||
const space = await laptop.createSpace('main') | ||
const space = await laptop.createSpace('main', { | ||
skipContentServeAuthorization: true, | ||
}) | ||
|
||
// want to provision space ? | ||
const email = '[email protected]' | ||
|
@@ -183,7 +187,9 @@ export const testAccount = Test.withContext({ | |
asserts.deepEqual(result.did, space.did()) | ||
}, | ||
'setup recovery': async (assert, { client, mail, grantAccess }) => { | ||
const space = await client.createSpace('test') | ||
const space = await client.createSpace('test', { | ||
skipContentServeAuthorization: true, | ||
}) | ||
|
||
const email = '[email protected]' | ||
const login = Account.login(client, email) | ||
|
@@ -280,7 +286,9 @@ export const testAccount = Test.withContext({ | |
assert, | ||
{ client, mail, grantAccess } | ||
) => { | ||
const space = await client.createSpace('test') | ||
const space = await client.createSpace('test', { | ||
skipContentServeAuthorization: true, | ||
}) | ||
|
||
const email = '[email protected]' | ||
const login = Account.login(client, email) | ||
|
@@ -299,8 +307,10 @@ export const testAccount = Test.withContext({ | |
assert.equal(typeof subs.results[0].subscription, 'string') | ||
}, | ||
|
||
'space.save': async (assert, { client, mail, grantAccess }) => { | ||
const space = await client.createSpace('test') | ||
'space.save': async (assert, { client }) => { | ||
const space = await client.createSpace('test', { | ||
skipContentServeAuthorization: true, | ||
}) | ||
assert.deepEqual(client.spaces(), []) | ||
|
||
const result = await space.save() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed lint issue