fix: publish location claim to content claims service #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
approved these changes
Nov 4, 2024
alanshaw
force-pushed
the
fix/publish-location-claim-to-content-claims-service
branch
from
8e946c2 to
496bf6a
Compare
Co-authored-by: Petra Jaros <[email protected]>
…f github.com:storacha/w3up into fix/publish-location-claim-to-content-claims-service
alanshaw
deleted the
fix/publish-location-claim-to-content-claims-service
branch
This was referenced Nov 28, 2024
alanshaw
pushed a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [18.1.4](upload-api-v18.1.3...upload-api-v18.1.4) (2024-11-28) ### Fixes * publish location claim to content claims service ([#1571](#1571)) ([fb08e0e](fb08e0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
added a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [16.5.2](w3up-client-v16.5.1...w3up-client-v16.5.2) (2024-11-29) ### Fixes * publish location claim to content claims service ([#1571](#1571)) ([fb08e0e](fb08e0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big oversight here, although I think the original intention was to have the client publish these so perhaps not.
Anyways, since no location claims are being published the gateway cannot fetch an index and serve bytes quickly. It has to get a location claim for every single block using the old dynamodb. Being able to use the index will result in a speed increase for serving content via the gateway.
Depends on storacha/content-claims#74 for passing tests.