feat!: updates agent-store api to unblock integration with w3infra #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
added a commit
to storacha/w3infra
that referenced
this pull request
May 30, 2024
Integrates agent-store into the infra and removes custom invocation execution and storage that was used previously. Requires storacha/w3up#1479 --------- Co-authored-by: Vasco Santos <[email protected]>
vasco-santos
added a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [17.0.0](upload-api-v16.0.0...upload-api-v17.0.0) (2024-05-30) ### ⚠ BREAKING CHANGES * updates agent-store api to unblock integration with w3infra ([#1479](#1479)) * **upload-api:** integrate agent store for idempotence & invocation/receipt persistence ([#1444](#1444)) ### Features * updates agent-store api to unblock integration with w3infra ([#1479](#1479)) ([2998a93](2998a93)) * **upload-api:** integrate agent store for idempotence & invocation/receipt persistence ([#1444](#1444)) ([c9bf33e](c9bf33e)) * use digest in `blob/accept` location commitment ([#1480](#1480)) ([ade45eb](ade45eb)) ### Fixes * rename blob and index client capabilities ([#1478](#1478)) ([17e3a31](17e3a31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vasco Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on storacha/w3infra#380 I have realized that agent-store API was poorly designed because it imposed:
This PR fixes above limitations by switching store interface from receiving
AgentMessagetoParsedAgentMessagewhich wrapsAgentMessagealong with message bytes and index freeing store from doing any kind of traversal or encoding.I also removed legacy code that was left behind by previous PR.