Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate agent store for idempotence & invocation/receipt persistence #1444
feat: integrate agent store for idempotence & invocation/receipt persistence #1444
Changes from 45 commits
9aee035
48cde40
d5672c8
0f1e592
1ccb3c4
dc40432
48a641e
99c1878
8ae5f69
2ff3748
8fb6720
5642e01
1f600c3
2c73702
50929e6
9391a86
45507f2
0896614
7552e9b
4eee857
24a99e9
c6aaa04
65dfee1
21e2973
f9c4043
5196f9c
fb21b1a
87915a9
1c886f1
c4c941a
e0b8619
c10ca5f
93faab5
0afa904
f5a960b
cf7e1f7
c89e9ce
49f275e
b67bb83
8d4a484
c8e0088
a3382e4
23c795f
6d513de
4b196c6
98889fb
3c403f1
1d6e557
c8a83d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be great to send this into a DLQ where we could be alerted. Probably an issue for now would be good, as we would also need to do the setup for DLQ monitoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably set this up as capability handler and dispatch to it, that way we would be able to throw here which will end up triggering
catch
handler of the server and get logged instead.Does that sound like a better option ?