Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test against actual api #1438

Merged
merged 8 commits into from
May 8, 2024
Merged

fix: test against actual api #1438

merged 8 commits into from
May 8, 2024

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented May 8, 2024

Removes mocks from tests everywhere in w3up client and tests against in-memory w3up service. This is aimed to help with #1425, which was suffering from issues caused by mocks

@Gozala Gozala requested review from alanshaw and joaosa May 8, 2024 05:49
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@joaosa joaosa merged commit f8132ca into main May 8, 2024
5 checks passed
@joaosa joaosa deleted the fix/no-mocks branch May 8, 2024 17:12
travis added a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[13.1.0](w3up-client-v13.0.1...w3up-client-v13.1.0)
(2024-05-14)


### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))


### Fixes

* test against actual api
([#1438](#1438))
([f8132ca](f8132ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
travis added a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.0.0](upload-api-v13.0.2...upload-api-v14.0.0)
(2024-05-14)


### ⚠ BREAKING CHANGES

* deprecate issuer
([#1344](#1344))

### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))
* deprecate issuer
([#1344](#1344))
([afbbde3](afbbde3))
* move blob index logic from upload-api to blob-index lib
([#1434](#1434))
([797f628](797f628))
* remove issuer row
([#1345](#1345))
([cf5b0db](cf5b0db))


### Fixes

* `encodeURIComponent` on bucket origin
([#1448](#1448))
([5618644](5618644))
* add format specifier to blob location claim URL
([#1445](#1445))
([9982d12](9982d12))
* test against actual api
([#1438](#1438))
([f8132ca](f8132ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants