Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove issuer row #1345

Merged
merged 2 commits into from
May 13, 2024
Merged

feat: remove issuer row #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe9ef4e
feat!: deprecate issuer field
Gozala Mar 26, 2024
f06dfde
feat: remove issuer field from row
Gozala Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/upload-api/src/store/add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function storeAddProvider(context) {
const space = /** @type {import('@ucanto/interface').DIDKey} */ (
Server.DID.parse(capability.with).did()
)
const issuer = invocation.issuer.did()

const [allocated, carExists] = await Promise.all([
allocate(
{
Expand All @@ -47,7 +47,6 @@ export function storeAddProvider(context) {
link,
size,
origin,
issuer,
invocation: invocation.cid,
})
if (res.error) {
Expand Down
7 changes: 6 additions & 1 deletion packages/upload-api/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,12 @@ export interface StoreAddInput {
link: UnknownLink
size: number
origin?: UnknownLink
issuer: DID

/**
* @deprecated - Issuer of the invocation is irrelevant as long as
* they have authorization to invoke on subject `space`.
*/
issuer?: DID
invocation: UCANLink
}

Expand Down
Loading