fix: upload client should perform filecoin offer #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/upload-client-should-perform-filecoin-offer
branch
2 times, most recently
from
24b95d2
to
00efec2
Compare
vasco-santos
force-pushed
the
fix/upload-client-should-perform-filecoin-offer
branch
from
00efec2
to
6f67eee
Compare
vasco-santos
commented
Mar 20, 2024
| @@ -93,7 +94,7 @@ export interface ProgressStatus extends XHRProgressStatus { | |||
|
|
|||
| export type ProgressFn = (status: ProgressStatus) => void | |||
|
|
|||
| export interface Service { | |||
| export interface Service extends StorefrontService { | |||
There was a problem hiding this comment.
adds storefront capabilities as implemented by upload-api per https://github.com/web3-storage/w3up/blob/main/packages/upload-api/src/types.ts#L164
alanshaw
approved these changes
Mar 21, 2024
| issuer: conf.issuer, | ||
| audience: conf.audience, | ||
| // Resource of storefront is the issuer did | ||
| with: conf.issuer.did(), |
There was a problem hiding this comment.
Not sure I understand why this is the issuer?
lolz looks like I wrote that comment...still why?
There was a problem hiding this comment.
my comment is actually also wrong, the did must be the same as the issuer in order to have a self issued invocation.. Otherwise you would need to either have been delegated such capability or inline proofs given resource is not did of issuer.
Co-authored-by: Alan Shaw <[email protected]>
vasco-santos
deleted the
fix/upload-client-should-perform-filecoin-offer
branch
This was referenced Mar 21, 2024
vasco-santos
added a commit
that referenced
this pull request
Mar 21, 2024
🤖 I have created a release *beep* *boop* --- ## [13.1.0](upload-client-v13.0.1...upload-client-v13.1.0) (2024-03-21) ### Features * byo piece hasher ([#1323](#1323)) ([fe2e3d5](fe2e3d5)) * non-parallel piece hashing and CAR upload ([#1305](#1305)) ([7a6385b](7a6385b)) * upgrade ucanto/transport to 9.1.0 in all packages to get more verbose errors from HTTP transport on non-ok response ([#1312](#1312)) ([d6978d7](d6978d7)) ### Fixes * upload client should perform filecoin offer ([#1333](#1333)) ([466e3f7](466e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Vasco Santos <[email protected]>
vasco-santos
added a commit
that referenced
this pull request
Mar 21, 2024
🤖 I have created a release *beep* *boop* --- ## [12.5.0](w3up-client-v12.4.1...w3up-client-v12.5.0) (2024-03-21) ### Features * upgrade ucanto/transport to 9.1.0 in all packages to get more verbose errors from HTTP transport on non-ok response ([#1312](#1312)) ([d6978d7](d6978d7)) ### Fixes * upload client should perform filecoin offer ([#1333](#1333)) ([466e3f7](466e3f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Vasco Santos <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of storacha/project-tracking#25 and storacha/w3infra#344 we set the client to perform filecoin/offer already so that new users, as well as users that upgrade in the meantime can already perform this, in order to better prepare us to get rid of bucket event