Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: receipt chain has wrong CID because no expiration is set #1060

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: receipt chain has wrong CID because no expiration is set #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb3170d
fix: receipt for aggregate accept has wrong cid
vasco-santos Nov 3, 2023
ef10873
fix: client
vasco-santos Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/filecoin-api/src/aggregator/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const pieceAccept = async ({ capability }, context) => {
aggregate,
pieces,
},
expiration: Infinity,
})
.delegate()

Expand Down
2 changes: 2 additions & 0 deletions packages/filecoin-api/test/services/aggregator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ export const test = {
piece,
group,
},
expiration: Infinity
})

const response = await pieceAcceptInv.execute(connection)
Expand Down Expand Up @@ -305,6 +306,7 @@ export const test = {
aggregate: aggregate.link,
pieces: piecesBlock.cid,
},
expiration: Infinity
})
.delegate()
assert.ok(response.fx.join)
Expand Down
2 changes: 2 additions & 0 deletions packages/filecoin-client/src/aggregator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export async function pieceOffer(
group,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down Expand Up @@ -101,6 +102,7 @@ export async function pieceAccept(
group,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down
2 changes: 2 additions & 0 deletions packages/filecoin-client/src/dealer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export async function aggregateOffer(
pieces: block.cid,
},
proofs,
expiration: Infinity,
})
invocation.attach(block)

Expand Down Expand Up @@ -103,6 +104,7 @@ export async function aggregateAccept(
pieces,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down
3 changes: 3 additions & 0 deletions packages/filecoin-client/src/storefront.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export async function filecoinOffer(
piece,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down Expand Up @@ -97,6 +98,7 @@ export async function filecoinSubmit(
piece,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down Expand Up @@ -140,6 +142,7 @@ export async function filecoinAccept(
piece,
},
proofs,
expiration: Infinity,
})

return await invocation.execute(conn)
Expand Down
1 change: 1 addition & 0 deletions packages/filecoin-client/test/aggregator.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ describe('aggregator', () => {
nb: {
...invCap.nb,
},
expiration: Infinity,
})
.delegate()

Expand Down
1 change: 1 addition & 0 deletions packages/filecoin-client/test/dealer.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ describe('dealer', () => {
audience: context.id,
with: context.id.did(),
nb: invCap.nb,
expiration: Infinity,
})
.delegate()

Expand Down
2 changes: 2 additions & 0 deletions packages/filecoin-client/test/storefront.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ describe('storefront', () => {
audience: context.id,
with: context.id.did(),
nb: invCap.nb,
expiration: Infinity,
})
.delegate()

Expand All @@ -58,6 +59,7 @@ describe('storefront', () => {
audience: context.id,
with: context.id.did(),
nb: invCap.nb,
expiration: Infinity,
})
.delegate()

Expand Down
Loading