Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement plan/get capability #1005

Merged
merged 15 commits into from
Oct 26, 2023
Merged

feat: implement plan/get capability #1005

merged 15 commits into from
Oct 26, 2023

Commits on Oct 24, 2023

  1. feat: implement plan/get capability 

    In console, we need a way to tell if a user has a subscription. Implement the `plan/get` capability from #959 to enable that.
    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8db017c View commit details
    Browse the repository at this point in the history

  2. fix: prettier plus export a couple more types

    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d521bef View commit details
    Browse the repository at this point in the history

  3. fix: a couple more additions

    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fb6a533 View commit details
    Browse the repository at this point in the history

  4. fix: add an error for plan/get

    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e3da5e4 View commit details
    Browse the repository at this point in the history

  5. feat: define PlansStorage interface 

    plus in-memory implementation and tests
    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bd60f44 View commit details
    Browse the repository at this point in the history

  6. feat: add plan service to top level service

    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e9985c1 View commit details
    Browse the repository at this point in the history

  7. fix: remove unused vars

    @travis
    travis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    956ecc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. feat: add function to access-client to get account plan 

    plus a tweak to plans-storage to return errors
    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ba21320 View commit details
    Browse the repository at this point in the history

  2. fixed: prettier

    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    515d39f View commit details
    Browse the repository at this point in the history

  3. feat: implement plan/get handler tests 

    I copied them from the ucan tests and neglected to actually implement them!
    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7a01a70 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/plan-get

    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    73554f2 View commit details
    Browse the repository at this point in the history

  5. fix: typo

    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    74f4328 View commit details
    Browse the repository at this point in the history

  6. fix: missing file extension

    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0f3c6d2 View commit details
    Browse the repository at this point in the history

  7. feat: alias string to ISO8601Date for clarity 

    We are already expecting ISO8601 dates in these fields, so per feedback in #1005 (comment) I'm creating a new ISO8601Date type aliased to `string` to better document that expectation.

We could get even more clever here, but I'd like to minimize changes while also moving toward a slightly better situation here, so this feels like a good compromise.
    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    34d1b01 View commit details
    Browse the repository at this point in the history

  8. chore: add test to ensure date is kept in 8601 format

    @travis
    travis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    95a1caa View commit details
    Browse the repository at this point in the history