Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): use allocated bytes in store/add receipt #303

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Dec 7, 2023

Uses allocated property in the store/add receipt to count bytes added to the space. The allocated property will be 0 when the user tries to add a shard that is already present in the space.

❓ should we store a diff anyway? even though the size did not change?

refs storacha/w3up#1213

@seed-deploy seed-deploy bot temporarily deployed to pr303 December 7, 2023 16:14 Inactive
@alanshaw alanshaw changed the title feat: use allocated bytes in store/add receipt feat(billing): use allocated bytes in store/add receipt Dec 7, 2023
Copy link

seed-deploy bot commented Dec 7, 2023

View stack outputs

@gobengo
Copy link
Contributor

gobengo commented Dec 8, 2023

❓ should we store a diff anyway? even though the size did not change?

I can't think of a good reason to

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit e4db048 into main Dec 12, 2023
3 checks passed
@alanshaw alanshaw deleted the feat/use-allocated-bytes-in-store-add-receipt branch December 12, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants