Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating w3up and upload-service #38

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 9, 2025

Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds involved enough that it should happen BEFORE we monorepo. Do you agree? (otherwise the merge could be complicated)

Am I correct that this would actually have the prod network working with the routing protocol? (just data would ONLY go to a single SP running CARPARK)

Overall makes sense if we can implement quickly. Is this something you can get help with or would it be just you? Maybe @fforbeck or @Peeja ?

@alanshaw
Copy link
Member Author

alanshaw commented Jan 10, 2025

This sounds involved enough that it should happen BEFORE we monorepo. Do you agree? (otherwise the merge could be complicated)

Yes agree.

Am I correct that this would actually have the prod network working with the routing protocol? (just data would ONLY go to a single SP running CARPARK)

Correct 😄

Overall makes sense if we can implement quickly. Is this something you can get help with or would it be just you? Maybe @fforbeck or @Peeja ?

I'd be happy to take this on and get it done ASAP.

It would make sense for the work to port changes from w3up to upload-service and to alter existing modules to import @storacha equivalents to be tackled concurrently by @fforbeck and/or @Peeja. Implementing the "maintenance mode" switch would also be useful to delegate.

@fforbeck
Copy link
Member

@alanshaw / @hannahhoward - Happy to help! I just need to wrap up the egress rollout, and then I’ll be ready to jump into the next task.

@alanshaw
Copy link
Member Author

@Peeja @fforbeck @hannahhoward FYI I've updated the migration strategy (write to both) and removed the task to create a maintenance switch. I'll merge this now and create an issue in the project planning with the task/people allocations we discussed.

@alanshaw alanshaw merged commit 2de3e81 into main Jan 15, 2025
@alanshaw alanshaw deleted the rfc/consolidating-w3up-and-upload-service branch January 15, 2025 11:06
alanshaw added a commit to storacha/upload-service that referenced this pull request Jan 15, 2025
This PR adds the legacy `store/*` and `admin/store/inspect` handlers
from the `@web3-storage/upload-api` in order to support deprecated
actions for a bit longer, per storacha/RFC#38

refs storacha/project-tracking#268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants