-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rulesets): validate unresolved AsyncAPI document #2262
Closed
magicmatatjahu
wants to merge
4
commits into
stoplightio:develop
from
magicmatatjahu:asyncapi/refs-validation
Closed
feat(rulesets): validate unresolved AsyncAPI document #2262
magicmatatjahu
wants to merge
4
commits into
stoplightio:develop
from
magicmatatjahu:asyncapi/refs-validation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
smoya,
jonaslagoni and
a team
as code owners
August 29, 2022 13:59
magicmatatjahu
commented
Aug 29, 2022
packages/rulesets/src/asyncapi/functions/asyncApi2DocumentSchema.ts
Outdated
Show resolved
Hide resolved
20 tasks
@magicmatatjahu is this ready to be reviewed or do you still need to do some work regarding #2262 (comment)? |
@jonaslagoni Yeah, when I will find time, I will create PR with |
9 tasks
magicmatatjahu
force-pushed
the
asyncapi/refs-validation
branch
from
September 26, 2022 12:32
65c3133
to
2d5cfb2
Compare
magicmatatjahu
commented
Sep 26, 2022
magicmatatjahu
force-pushed
the
asyncapi/refs-validation
branch
from
September 27, 2022 11:51
6a1b284
to
7654801
Compare
P0lip
force-pushed
the
develop
branch
2 times, most recently
from
December 14, 2022 15:55
cf3ae99
to
761c65a
Compare
Any update on this one @magicmatatjahu? Or do you want to close it? |
P0lip
force-pushed
the
develop
branch
4 times, most recently
from
May 23, 2023 20:53
4b6a9e1
to
33deb2b
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
May 23, 2023 22:56
dc9d7f4
to
44c40e2
Compare
P0lip
force-pushed
the
develop
branch
4 times, most recently
from
June 9, 2023 19:43
02ec0d4
to
84faec8
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
September 20, 2023 18:42
9e92f34
to
6d09915
Compare
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
April 4, 2024 13:29
dc90b7a
to
c22f408
Compare
Closing as stale. Feel free to open if needed. @jonaslagoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2261.
Checklist
Does this PR introduce a breaking change?
Screenshots
The following AsyncAPI document is invalid and Spectral should throw errors due to invalid defined references (in impossible places):
and Spectral will return errors: