fix(docker): Updated to newest version of alpine linux and fixed missing dependencies #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonith404
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Awesome thank you very much! One little thing: please add the
HOSTNAME=0.0.0.0 fixes vercel/next.js#51684. It can be removed as soon as the issue is fixed
comment back.
Co-authored-by: Elias Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change the docker OS to the newest version of Alpine Linux, therefore saving around 1/5th of the base ram usage (as mentioned in #241) compared to the image live on Docker hub. It also makes the image more secure by being up-to date.
Added the manual installation of curl, which fixed the issue of containers always showing up as unhealthy when built from the previous Dockerfile.