Fix lattice volume calculation #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the output file volume was incorrect. It was printed under the 'unitcell' heading, but the code indicatated it was the supercell volume, but the printing happens before the supercell is generated. So in the end it was always the volume of a cubic unit cell. I've removed the volume() method from the lattice class to avoid any ambiguity about what this volume corresponds to. Now in the unit cell and lattice sections I output the correct volumes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the output file volume was incorrect. It was printed under the 'unitcell' heading, but the code indicatated it was the supercell volume, but the printing happens before the supercell is generated. So in the end it was always the volume of a cubic unit cell.
I've removed the volume() method from the lattice class to avoid any ambiguity about what this volume corresponds to. Now in the unit cell and lattice sections I output the correct volumes.