Pass client in beforeConnect #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm facing the same issue as stomp-js/rx-stomp#204 in the rx-stomp library:
We are using access tokens with a short lifetime of ~5 minutes and passing these tokens as a connect header on the initial CONNECT message. If the websocket connection breaks after the access token is expired, it is not possible to supply a refreshed access token, the expired token is still used on the reconnnect. Of course, that reconnect fails because the old token is expired. In the linked issue, the problem was fixed by passing the client object to the
beforeConnectcallback, I've done the same here.Feel free to comment on, or edit my changes!
Best
Nikos