Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.10] Upgrade to Thanos v0.32.5 #90

Conversation

saswatamcode
Copy link
Member

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Changelog and upstream Thanos release specify all the changes included in this

Verification

saswatamcode and others added 2 commits November 8, 2023 09:49
* update objstore version to latest (thanos-io#6746)

Signed-off-by: Ben Ye <[email protected]>

* Cut patch release v0.32.4

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Co-authored-by: Ben Ye <[email protected]>
* Build with Go 1.21 (thanos-io#6615)

* Build with Go 1.21

Signed-off-by: Saswata Mukherjee <[email protected]>

* Update tools

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>

* update go alpine image to 3.18 (thanos-io#6750)

Signed-off-by: Coleen Iona Quadros <[email protected]>

* build(deps): bump golang.org/x/net from 0.14.0 to 0.17.0 (thanos-io#6805)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0.
- [Commits](golang/net@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updates busybox SHA (thanos-io#6808)

Signed-off-by: GitHub <[email protected]>
Co-authored-by: fpetkovski <[email protected]>

* Fix matchersToPostingGroups vals variable shadow bug (thanos-io#6817)

* fix matchersToPostingGroups vals variable shadow bug

Signed-off-by: Ben Ye <[email protected]>

* update changelog

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>

* fix head series limiter trigger (thanos-io#6802)

Signed-off-by: Thibault Mange <[email protected]>

* Store: fix prometheus store label values for matches on external labels (thanos-io#6816)

External Labels should also be tested for matches against the matchers.

Signed-off-by: Michael Hoffmann <[email protected]>

* Cut patch release v0.32.5

Signed-off-by: Saswata Mukherjee <[email protected]>

* Revert "Fix matchersToPostingGroups vals variable shadow bug (thanos-io#6817)"

This reverts commit 4ed9bb0.

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]>
Co-authored-by: Coleen Iona Quadros <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: fpetkovski <[email protected]>
Co-authored-by: Ben Ye <[email protected]>
Co-authored-by: Thibault Mange <[email protected]>
Co-authored-by: Michael Hoffmann <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Copy link

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri
Copy link

@saswatamcode holding off this merge while we get ACM 2.9 out. Looks like they need to respin the downstream

@saswatamcode
Copy link
Member Author

@subbarao-meduri wouldn't ACM 2.9 be more stable, if we had this in place?

@douglascamata
Copy link

What's "respin the downstream"?

@subbarao-meduri subbarao-meduri changed the base branch from release-2.9 to release-2.10 January 23, 2024 13:04
@subbarao-meduri subbarao-meduri changed the title [release-2.9] Upgrade to Thanos v0.32.5 [release-2.10] Upgrade to Thanos v0.32.5 Jan 23, 2024
Copy link

openshift-ci bot commented Jan 23, 2024

@saswatamcode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kind 2e83304 link true /test e2e-kind
ci/prow/pr-image-mirror 2e83304 link true /test pr-image-mirror
ci/prow/images 2e83304 link true /test images
ci/prow/test-unit 2e83304 link true /test test-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subbarao-meduri
Copy link

superseded by #99 - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants