Skip to content

Commit

Permalink
fix conflict
Browse files Browse the repository at this point in the history
Signed-off-by: Coleen Iona Quadros <[email protected]>
  • Loading branch information
coleenquadros committed Sep 2, 2024
1 parent 4ab7310 commit 00947b6
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 172 deletions.
157 changes: 1 addition & 156 deletions pkg/api/query/querypb/query.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/logging/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package logging
import (
"context"
"fmt"
"math/rand"
"time"

"github.com/oklog/ulid"
Expand Down
1 change: 0 additions & 1 deletion pkg/queryfrontend/queryinstant_codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"github.com/prometheus/prometheus/promql/parser"
"github.com/weaveworks/common/httpgrpc"

"github.com/prometheus/prometheus/promql/parser"
"github.com/thanos-io/thanos/internal/cortex/cortexpb"
"github.com/thanos-io/thanos/internal/cortex/querier/queryrange"
cortexutil "github.com/thanos-io/thanos/internal/cortex/util"
Expand Down
4 changes: 0 additions & 4 deletions pkg/querysharding/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ var (
notShardableErr = fmt.Errorf("expressions are not shardable")
)

var (
notShardableErr = fmt.Errorf("expressions are not shardable")
)

type Analyzer interface {
Analyze(string) (QueryAnalysis, error)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/receive/multitsdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func (t *tenant) store() *store.TSDBStore {
return t.storeTSDB
}

func (t *tenant) client(logger log.Logger) store.Client {
func (t *tenant) client() store.Client {
t.mtx.RLock()
defer t.mtx.RUnlock()

Expand Down
9 changes: 0 additions & 9 deletions pkg/store/bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -1072,11 +1072,6 @@ func newBlockSeriesClient(
extLset = rmLabels(extLset.Copy(), extLsetToRemove)
}

extLset := b.extLset
if extLsetToRemove != nil {
extLset = rmLabels(extLset.Copy(), extLsetToRemove)
}

return &blockSeriesClient{
ctx: ctx,
logger: logger,
Expand Down Expand Up @@ -2963,7 +2958,6 @@ func (r *bucketIndexReader) fetchPostings(ctx context.Context, keys []labels.Lab
if err := bytesLimiter.ReserveWithType(uint64(len(dataFromCache)), PostingsTouched); err != nil {
return nil, closeFns, httpgrpc.Errorf(int(codes.ResourceExhausted), "exceeded bytes limit while loading postings from index cache: %s", err)
}
r.stats.DataDownloadedSizeSum += units.Base2Bytes(len(dataFromCache))
}

// Iterate over all groups and fetch posting from cache.
Expand Down Expand Up @@ -3019,7 +3013,6 @@ func (r *bucketIndexReader) fetchPostings(ctx context.Context, keys []labels.Lab
if err := bytesLimiter.ReserveWithType(uint64(length), PostingsFetched); err != nil {
return nil, closeFns, httpgrpc.Errorf(int(codes.ResourceExhausted), "exceeded bytes limit while fetching postings: %s", err)
}
r.stats.DataDownloadedSizeSum += units.Base2Bytes(length)
}

g, ctx := errgroup.WithContext(ctx)
Expand Down Expand Up @@ -3195,7 +3188,6 @@ func (r *bucketIndexReader) PreloadSeries(ctx context.Context, ids []storage.Ser
if err := bytesLimiter.ReserveWithType(uint64(len(b)), SeriesTouched); err != nil {
return httpgrpc.Errorf(int(codes.ResourceExhausted), "exceeded bytes limit while loading series from index cache: %s", err)
}
r.stats.DataDownloadedSizeSum += units.Base2Bytes(len(b))
}

parts := r.block.partitioner.Partition(len(ids), func(i int) (start, end uint64) {
Expand Down Expand Up @@ -3526,7 +3518,6 @@ func (r *bucketChunkReader) load(ctx context.Context, res []seriesEntry, aggrs [
if err := bytesLimiter.ReserveWithType(uint64(p.End-p.Start), ChunksFetched); err != nil {
return httpgrpc.Errorf(int(codes.ResourceExhausted), "exceeded bytes limit while fetching chunks: %s", err)
}
r.stats.DataDownloadedSizeSum += units.Base2Bytes(p.End - p.Start)
}

for _, p := range parts {
Expand Down
2 changes: 1 addition & 1 deletion pkg/store/proxy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,7 @@ func TestStoreMatches(t *testing.T) {
},
} {
t.Run("", func(t *testing.T) {
ok, reason := storeMatches(context.TODO(), c.s, true, c.mint, c.maxt, c.ms...)
ok, reason := storeMatches(context.TODO(), c.s, c.mint, c.maxt, c.ms...)
testutil.Equals(t, c.expectedMatch, ok)
testutil.Equals(t, c.expectedReason, reason)

Expand Down

0 comments on commit 00947b6

Please sign in to comment.