Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TemplateEngine and ClusterInstance packages #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor TemplateEngine and ClusterInstance packages #116

wants to merge 1 commit into from
+1,203 −1,032

Commits on Oct 9, 2024

  1. Refactor TemplateEngine and ClusterInstance packages 

    This commit refactors the TemplateEngine used to render install templates. The following changes are made:
- Refactor TemplateEngine into an interface type defined under internal/templates/engine.
- Define a concrete ClusterInstance TemplateEngine type that implements the interface.
- Refactor the clusterinstance package by separating the ClusterData into its own source file.
- Refactor the clusterinstance package by moving commonly used functions and constants to internal/controller/common package.
- Reorganized rendered_object.go source file (along with its unit tests) to internal/templates/engine/.
- Renamed the imagebasedinstall package to imagebasedinstaller.
- Added Red Hat copyright headers to internal/controller/conditions and internal/controller/retry source files.

Signed-off-by: Sharat Akhoury <[email protected]>
    @sakhoury
    sakhoury committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    38d004a View commit details
    Browse the repository at this point in the history