Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver related readme recursive example typo #242

Merged

Conversation

smcavey
Copy link
Contributor

@smcavey smcavey commented Aug 29, 2024

Description of changes

  • Correct small typo in resolver related_readme.md example where end of recursive part was labeled as start

Copy link

openshift-ci bot commented Aug 29, 2024

Hi @smcavey. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smcavey smcavey force-pushed the related-readme-recursion-example-typo branch from 7dea349 to 2dc83aa Compare August 29, 2024 18:10
Copy link

github-actions bot commented Sep 4, 2024

This pr has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days (1 week), if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 4, 2024
Copy link
Contributor

@jlpadilla jlpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@jlpadilla
Copy link
Contributor

/lgtm

@jlpadilla jlpadilla removed the stale label Sep 10, 2024
Copy link

@jlpadilla
Copy link
Contributor

/test tide

Copy link

openshift-ci bot commented Sep 10, 2024

@jlpadilla: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test lint
  • /test pr-image-mirror
  • /test sonar-pre-submit
  • /test test-unit

Use /test all to run all jobs.

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jlpadilla
Copy link
Contributor

/remove-approve
(Trying to reset konflux check showing "pending approval".)

@openshift-ci openshift-ci bot removed the approved label Sep 10, 2024
@jlpadilla
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlpadilla, smcavey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlpadilla jlpadilla merged commit 37dbb5c into stolostron:main Sep 10, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants