Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wlp annotation if necessary for 2.1 #47

Open
wants to merge 1 commit into
base: backplane-2.1
Choose a base branch
from
Open

add wlp annotation if necessary for 2.1 #47

wants to merge 1 commit into from

Conversation

elgnay
Copy link

@elgnay elgnay commented Jul 4, 2023

@elgnay elgnay force-pushed the ensure-wlp-annotation-2.1 branch 4 times, most recently from 2ffc09a to f25bab5 Compare August 8, 2023 03:06
@elgnay elgnay changed the title add wlp annotation if necessary add wlp annotation if necessary for 2.1 Aug 8, 2023
@elgnay
Copy link
Author

elgnay commented Aug 8, 2023

/hold Hold until the 2.1 branch is open for business.

@elgnay
Copy link
Author

elgnay commented Aug 10, 2023

Make sure merge stolostron/managedcluster-import-controller#269 first.

@elgnay elgnay force-pushed the ensure-wlp-annotation-2.1 branch from f25bab5 to 4dbca27 Compare August 21, 2023 07:34
@elgnay
Copy link
Author

elgnay commented Aug 21, 2023

/test e2e

@zhiweiyin318
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zhiweiyin318 zhiweiyin318

Labels
approved dco-signoff: yes do-not-merge/hold lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgnay @zhiweiyin318