Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code smell #28

Merged
merged 1 commit into from
May 14, 2020
Merged

fix code smell #28

merged 1 commit into from
May 14, 2020

Conversation

songleo
Copy link
Member

@songleo songleo commented May 13, 2020

No description provided.

@songleo songleo force-pushed the add-ut branch 2 times, most recently from 4cc46c7 to 2d4f685 Compare May 13, 2020 14:21
@songleo songleo changed the title [wip] fix code smell fix code smell May 13, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

53.3% 53.3% Coverage
0.0% 0.0% Duplication

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clyang82, songleo
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82 clyang82 merged commit 4f47e11 into master May 14, 2020
@clyang82 clyang82 deleted the add-ut branch May 14, 2020 01:17
jacobbaungard pushed a commit to jacobbaungard/multicluster-observability-operator that referenced this pull request Dec 19, 2024
…ry-pick-27-to-main

[main] fix disabled cr to checkaddon issue in 2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants