Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip pull secret when creating manifestwork if it doesn't exist #268

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

marcolan018
Copy link
Contributor

@marcolan018 marcolan018 commented Nov 10, 2020

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clyang82, marcolan018
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marcolan018 marcolan018 merged commit b92dd60 into release-2.1 Nov 11, 2020
@marcolan018 marcolan018 deleted the skippull-2.1.1 branch November 11, 2020 14:41
@smithbw88
Copy link
Contributor

Hi guys, looks like the e2e tests failed, so this did not get pushed to the pipeline. Can you remediate the failure?

jacobbaungard added a commit to jacobbaungard/multicluster-observability-operator that referenced this pull request Dec 19, 2024
Signed-off-by: Jacob Baungard Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants