Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip inject pull secret into manifestwork if it doesn't exist #264

Closed
wants to merge 2 commits into from

Conversation

marcolan018
Copy link
Contributor

@marcolan018 marcolan018 commented Nov 9, 2020

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcolan018
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor

Can we add a test case to cover this scenario?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@marcolan018 marcolan018 requested a review from clyang82 November 11, 2020 02:56
@clyang82
Copy link
Contributor

@marcolan018 this PR should go to master, right?

@marcolan018 marcolan018 deleted the pullsecret branch November 11, 2020 15:05
jacobbaungard pushed a commit to jacobbaungard/multicluster-observability-operator that referenced this pull request Dec 19, 2024
…error_status_last_transition_timestamp_seconds

ignore kubevirt_vm_error_status_last_transition_timestamp_seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants