Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pv metrics #263

Merged
merged 2 commits into from
Nov 9, 2020
Merged

add pv metrics #263

merged 2 commits into from
Nov 9, 2020

Conversation

songleo
Copy link
Member

@songleo songleo commented Nov 9, 2020

@clyang82
Copy link
Contributor

clyang82 commented Nov 9, 2020

FYI @bjoydeep

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clyang82, songleo
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor

clyang82 commented Nov 9, 2020

We need to rerun the test cases once #262 is merged, because #262 include
git checkout release-2.1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@clyang82 clyang82 merged commit aced5c1 into release-2.1 Nov 9, 2020
@clyang82 clyang82 deleted the add-pv-metrics branch November 9, 2020 14:15
jacobbaungard pushed a commit to jacobbaungard/multicluster-observability-operator that referenced this pull request Dec 19, 2024
…non_running_status_last_transition_timestamp_seconds

ignore metrics kubevirt_vm_non_running_status_last_transition_timesta…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants