[ACM-12908]Swap out cmo dependency for local structs #1547
Conversation
philipgough
changed the title
philipgough
force-pushed
the
ACM-12908
branch
2 times, most recently
from
99316ab to
11d748e
Compare
pkg/cmo/api.go
Outdated
There was a problem hiding this comment.
Maybe this could live in the already existing operators/pkg folder instead of a new pkg folder as the repo root?
There was a problem hiding this comment.
Also it could be a good idea to have a comment documenting the original source of all this code (so that we know where to look for updates to it) and its own license & copyright notice (if needed).
Signed-off-by: Philip Gough <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglascamata, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3f5ae1a
into
stolostron:release-2.11
This change introduces a like for like copy of the relevant source code in order to avoid the dependency issues we had when trying to upgrade https://github.com/openshift/cluster-monitoring-operator on this branch.
#1523 updates the dependencies across the project and is the preferred solution going forward.