[ACM-9321] Stop firing IngressWithoutClassName alert #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoydeep
approved these changes
Feb 6, 2024
|
/lgtm |
|
/test e2e-kind |
Signed-off-by: Subbarao Meduri <[email protected]>
subbarao-meduri
force-pushed
the
fix-alert-ingresswithout-classname
branch
from
63d3da8 to
4cd6195
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bjoydeep, douglascamata, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
coleenquadros
pushed a commit
to coleenquadros/multicluster-observability-operator
that referenced
this pull request
Feb 10, 2024
…rt (stolostron#1312) Signed-off-by: Subbarao Meduri <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]>
philipgough
pushed a commit
to philipgough/multicluster-observability-operator
that referenced
this pull request
Feb 13, 2024
…rt (stolostron#1312) Signed-off-by: Subbarao Meduri <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
…rt (#1312) (#1327) Signed-off-by: Subbarao Meduri <[email protected]> Co-authored-by: Subbarao Meduri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://issues.redhat.com/browse/OCPBUGS-18537, define .spec.ingressClassName so IngressWithoutClassName alert does not fire.