Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.9] Add support for custom proxy ca (#1293) #1302

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[release-2.9] Add support for custom proxy ca (#1293) #1302

merged 1 commit into from
Jan 24, 2024
+130 −24

Conversation

coleenquadros
Copy link
Contributor

Cherry pick custom proxy ca to release 2.9

  • add support for proxy ca

@coleenquadros
Add support for custom proxy ca (stolostron#1293)
5b87a27 
* add support for proxy ca

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor proxy ca parsing

Signed-off-by: Coleen Iona Quadros <[email protected]>

---------

Signed-off-by: Coleen Iona Quadros <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

66.7% Coverage on New Code (required ≥ 70%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 24, 2024

@coleenquadros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 5b87a27 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

subbarao-meduri
subbarao-meduri approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@subbarao-meduri subbarao-meduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri subbarao-meduri merged commit 15a50b9 into stolostron:release-2.9 Jan 24, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbarao-meduri subbarao-meduri subbarao-meduri approved these changes

@douglascamata douglascamata Awaiting requested review from douglascamata

Assignees

@subbarao-meduri subbarao-meduri

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coleenquadros @subbarao-meduri