Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] add watch logic for addondeployment (#1289) #1301

Conversation

subbarao-meduri
Copy link
Collaborator

https://issues.redhat.com/browse/ACM-8312

Back port PR 12890 to ACM 2.9 (cherry pick commit 7fb7465)

  • add watch logic for addondeployment
  • make sonarcloud happy
  • lint
  • refactor predicate
  • lint
  • fix test case
  • refactor

@openshift-ci openshift-ci bot added the lgtm label Jan 18, 2024
@subbarao-meduri subbarao-meduri changed the base branch from main to release-2.9 January 18, 2024 15:53
@subbarao-meduri
Copy link
Collaborator Author

/test e2e-kind

Copy link

openshift-ci bot commented Jan 18, 2024

@subbarao-meduri: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test sonarcloud
  • /test test-e2e
  • /test test-unit

Use /test all to run all jobs.

In response to this:

/test e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subbarao-meduri
Copy link
Collaborator Author

/test ci/prow/e2e-kind

Copy link

openshift-ci bot commented Jan 18, 2024

@subbarao-meduri: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test sonarcloud
  • /test test-e2e
  • /test test-unit

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coleenquadros
Copy link
Contributor

/test all

@coleenquadros
Copy link
Contributor

/retest

@coleenquadros
Copy link
Contributor

/test e2e-kind

Copy link

openshift-ci bot commented Jan 23, 2024

@coleenquadros: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test sonarcloud
  • /test test-e2e
  • /test test-unit

Use /test all to run all jobs.

In response to this:

/test e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* add watch logic for addondeployment

Signed-off-by: Coleen Iona Quadros <[email protected]>

* make sonarcloud happy

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor predicate

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* fix test case

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor

Signed-off-by: Coleen Iona Quadros <[email protected]>

---------

Signed-off-by: Coleen Iona Quadros <[email protected]>
@subbarao-meduri subbarao-meduri force-pushed the 29-addon-deployment-watch-logic branch from 4577997 to 5c4b631 Compare January 24, 2024 15:46
@openshift-ci openshift-ci bot removed the lgtm label Jan 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

47.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 24, 2024

@subbarao-meduri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kind 4577997 link true /test e2e-kind
ci/prow/sonarcloud 5c4b631 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri subbarao-meduri merged commit ae7d158 into stolostron:release-2.9 Jan 24, 2024
5 of 8 checks passed
@subbarao-meduri subbarao-meduri deleted the 29-addon-deployment-watch-logic branch March 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants