Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch logic for addondeploymentconfig #1287

Closed

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Dec 1, 2023

https://issues.redhat.com/browse/RHOBS-949
https://issues.redhat.com/browse/ACM-8312

From what I understand is that the placement controller has no logic to watch over the changes to addondeployment config. So any update to it will not be picked up by managerclusteraddon and clustermanagementaddon which are watched already but they only hold a ref to addondeploymentconfig and not the actual config.

The PR adds the watch logic in the placement controller to monitor changes in addondeployment config and sets up the request to reconcile and also apply change to all managed clusters

Copy link

openshift-ci bot commented Dec 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros coleenquadros changed the title add watch logic for addondeploymentconfig Add watch logic for addondeploymentconfig Dec 5, 2023
@coleenquadros coleenquadros force-pushed the update_mco_on_proxy_cfg branch 2 times, most recently from 42a4de1 to 69642f7 Compare December 5, 2023 14:29
Copy link

openshift-ci bot commented Dec 5, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 2148f23 Merge remote-tracking branch 'origin' into update_mco_on_proxy_cfg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coleenquadros
Once this PR has been reviewed and has the lgtm label, please assign songleo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Dec 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

27.0% 27.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@philipgough
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Dec 5, 2023

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 47266f4 link true /test sonarcloud
ci/prow/e2e-kind 47266f4 link true /test e2e-kind

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants