-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watch logic for addondeploymentconfig #1287
Add watch logic for addondeploymentconfig #1287
Conversation
Signed-off-by: Coleen Iona Quadros <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
7651ff9
to
64fd755
Compare
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
4bb2304
to
46f42e1
Compare
Signed-off-by: Coleen Iona Quadros <[email protected]>
46f42e1
to
42ed8e3
Compare
Signed-off-by: Coleen Iona Quadros <[email protected]>
42a4de1
to
69642f7
Compare
69642f7
to
47266f4
Compare
47266f4
to
3b4af91
Compare
cc0bba0
to
47266f4
Compare
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coleenquadros The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SonarCloud Quality Gate failed. 0 Bugs 27.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/retest |
@coleenquadros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/RHOBS-949
https://issues.redhat.com/browse/ACM-8312
From what I understand is that the placement controller has no logic to watch over the changes to addondeployment config. So any update to it will not be picked up by managerclusteraddon and clustermanagementaddon which are watched already but they only hold a ref to addondeploymentconfig and not the actual config.
The PR adds the watch logic in the placement controller to monitor changes in addondeployment config and sets up the request to reconcile and also apply change to all managed clusters