Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear gosec false positives #1275

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Oct 31, 2023

ACM-6937

Mostly a cherry pick of the gosec false-positives skips from #1259.

Signed-off-by: Douglas Camata <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@coleenquadros
Copy link
Contributor

/lgtm

@douglascamata
Copy link
Contributor Author

@songleo can you please review this? Thanks!

Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, douglascamata, songleo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@openshift-ci openshift-ci bot merged commit 0f03a35 into release-2.8 Nov 1, 2023
2 checks passed
@openshift-ci openshift-ci bot deleted the 2.8-gosec-false-positives branch November 1, 2023 03:16
douglascamata added a commit that referenced this pull request Nov 3, 2023
* Clear up gosec false positives

Signed-off-by: Douglas Camata <[email protected]>

* Correclty skip gosec false positive

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>
douglascamata added a commit that referenced this pull request Nov 3, 2023
* Clear up gosec false positives

Signed-off-by: Douglas Camata <[email protected]>

* Correclty skip gosec false positive

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>
douglascamata added a commit that referenced this pull request Nov 3, 2023
* Clear `gosec` false positives (#1275)

* Clear up gosec false positives

Signed-off-by: Douglas Camata <[email protected]>

* Correclty skip gosec false positive

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>

* Rerun build

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>
douglascamata added a commit that referenced this pull request Nov 3, 2023
* Clear up gosec false positives



* Correclty skip gosec false positive



---------

Signed-off-by: Douglas Camata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants