Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACING-4207: add support for Instrumentation CR #59

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

iblancasa
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10810415250

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.164%

Totals Coverage Status
Change from base Build 10770330531: 0.0%
Covered Lines: 164
Relevant Lines: 292

💛 - Coveralls

@iblancasa iblancasa marked this pull request as ready for review August 22, 2024 09:15
@iblancasa iblancasa requested review from a team as code owners August 22, 2024 09:15
@iblancasa iblancasa self-assigned this Aug 22, 2024
@JoaoBraveCoding
Copy link
Collaborator

JoaoBraveCoding commented Aug 26, 2024

Also, can you share some steps on how to test this on a cluster? I've never played with the Instrumentation resource. Adding the required resources to hack and providing the steps it is also fine.

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa
Copy link
Contributor Author

Also, can you share some steps on how to test this on a cluster? I've never played with the Instrumentation resource. Adding the required resources to hack and providing the steps it is also fine.

I added one Instrumentation object to be used as stanza and one workload (to deploy in the spoke cluster) to automatically instrument it.

I have to retest everything but having some issues with my installation.

@JoaoBraveCoding
Copy link
Collaborator

I have to retest everything but having some issues with my installation.

No problem, do let me know when I can also give it a spin on my side 👍

BTW: you named your Instrumentation python but then in the CMA you are looking for one called instance that might be where things are going wrong.

Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested and indeed pods on the spoke are getting instrumentation injected.
image

@JoaoBraveCoding JoaoBraveCoding merged commit 1981354 into stolostron:main Sep 12, 2024
3 checks passed
@iblancasa iblancasa deleted the TRACING-4207 branch September 12, 2024 10:06
JoaoBraveCoding added a commit to JoaoBraveCoding/multicluster-observability-operator that referenced this pull request Sep 12, 2024
openshift-merge-bot bot pushed a commit to stolostron/multicluster-observability-operator that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants