Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon: use labels instead of annotations to determine hub cluster #50

Merged
merged 1 commit into from
May 29, 2024
Merged

addon: use labels instead of annotations to determine hub cluster #50

merged 1 commit into from
May 29, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented May 29, 2024 •
edited
Loading

In #48 I've incorrectly used annotations instead of labels to determine if a cluster is the hub cluster.

Fix secret keys for CLF when forwarding logs to CW

@JoaoBraveCoding JoaoBraveCoding requested review from a team as code owners May 29, 2024 16:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9290024008

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.554%
Totals Coverage Status
Change from base Build 9288125643: 0.0%
Covered Lines: 187
Relevant Lines: 314
💛 - Coveralls

@periklis periklis merged commit f32869f into stolostron:main May 29, 2024
3 checks passed
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoBraveCoding @coveralls @periklis